Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/enhance search #67

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Feature/enhance search #67

wants to merge 13 commits into from

Conversation

bertearazvan
Copy link
Contributor

@bertearazvan bertearazvan commented Feb 1, 2021 •
edited
Loading

What does it fix?

  • It adds a county dropdown and filters the search results by the given county. Moreover, it renders the extended results underneath the search bar. If there is no search criteria, the user is being redirected to /asociatii.
  • It also fixes the bug where the searchbar was not responsive on screen resize.
  • I have primarily checked the mainpage and /asociatii as I haven't seen the searchbar on other pages. Otherwise, let me know 👍🏼

How has it been tested?

The app was tested locally and I have created a staging deployment with raw data on this link.

@savornicesei
Copy link

This is a must have feature, as we're already in May. Can it be reviewed and deployed, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertearazvan @savornicesei