Bundle Analysis: fix routes and add sizes to RouteChange #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerrySentry
commented
Dec 5, 2024
| @@ -304,8 +304,10 @@ def routes(self) -> Dict[str, List[AssetReport]]: | |||
| """ | |||
| route_map = defaultdict(list) | |||
| for asset_report in self.asset_reports(): | |||
| for route in asset_report.routes(): | |||
| route_map[route].append(asset_report) | |||
There was a problem hiding this comment.
fixes a bug where routes is null
suejung-sentry
approved these changes
Dec 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 90.54% 89.98% -0.56%
==========================================
Files 400 324 -76
Lines 12445 9218 -3227
Branches 2097 1636 -461
==========================================
- Hits 11268 8295 -2973
+ Misses 1069 860 -209
+ Partials 108 63 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need the absolute sizes for Route in PR comments
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.