-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Remove dollar signs from email templates #887
base: main
Are you sure you want to change the base?
Conversation
e751626
to
2606688
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 444 444
Lines 35420 35420
=======================================
Hits 34712 34712
Misses 708 708
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 444 444
Lines 35420 35420
=======================================
Hits 34712 34712
Misses 708 708
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 444 444
Lines 35420 35420
=======================================
Hits 34712 34712
Misses 708 708
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 444 444
Lines 35420 35420
=======================================
Hits 34712 34712
Misses 708 708
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Going to have the caller specify the currency string instead of just a number. Easy to do now to make supporting more currency formats easier in the future.