Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove dollar signs from email templates #887

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

spalmurray-codecov
Copy link
Contributor

Going to have the caller specify the currency string instead of just a number. Easy to do now to make supporting more currency formats easier in the future.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review November 12, 2024 23:10
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/billing-email-dollar-sign branch from e751626 to 2606688 Compare November 12, 2024 23:11
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (b6854d4) to head (2606688).
Report is 25 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35420    35420           
=======================================
  Hits        34712    34712           
  Misses        708      708           
Flag Coverage Δ
integration 41.95% <ø> (ø)
unit 90.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <ø> (ø)
OutsideTasks 95.86% <ø> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35420    35420           
=======================================
  Hits        34712    34712           
  Misses        708      708           
Flag Coverage Δ
integration 41.95% <ø> (ø)
unit 90.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <ø> (ø)
OutsideTasks 95.86% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (b6854d4) to head (2606688).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35420    35420           
=======================================
  Hits        34712    34712           
  Misses        708      708           
Flag Coverage Δ
integration 41.95% <ø> (ø)
unit 90.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <ø> (ø)
OutsideTasks 95.86% <ø> (ø)

Copy link

codecov-public-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (b6854d4) to head (2606688).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files         444      444           
  Lines       35420    35420           
=======================================
  Hits        34712    34712           
  Misses        708      708           
Flag Coverage Δ
integration 41.95% <ø> (ø)
unit 90.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <ø> (ø)
OutsideTasks 95.86% <ø> (ø)

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants