Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new UploadErrorCode value for processing timeouts #945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Dec 6, 2024

sibling PRs:

merge after the API PR has been deployed

when we receive a SoftTimeLimitExceeded exception we will now attempt to stop and save an upload error, but it's possible that we will get a hard timeout before we can actually commit. so there may still be timeouts that aren't properly coded. but hopefully for a lot of them we can display something more descriptive

Copy link

github-actions bot commented Dec 6, 2024

This PR includes changes to shared. Please review them here: codecov/shared@45252f7...2262286

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 26.14%. Comparing base (96bed1f) to head (e6a3cfa).

Files with missing lines Patch % Lines
services/report/__init__.py 0.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (96bed1f) and HEAD (e6a3cfa). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (96bed1f) HEAD (e6a3cfa)
unit 2 1
integration 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #945       +/-   ##
===========================================
- Coverage   97.99%   26.14%   -71.85%     
===========================================
  Files         445      445               
  Lines       35754    35760        +6     
===========================================
- Hits        35036     9350    -25686     
- Misses        718    26410    +25692     
Flag Coverage Δ
integration ?
unit 26.14% <0.00%> (-64.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
services/report/__init__.py 0.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (96bed1f) and HEAD (e6a3cfa). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (96bed1f) HEAD (e6a3cfa)
unit 2 1
integration 2 0

📢 Thoughts on this report? Let us know!

Copy link

github-actions bot commented Dec 6, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants