Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.4 bugfixes #159

Merged
merged 19 commits into from
Jul 15, 2024
Merged

0.4 bugfixes #159

merged 19 commits into from
Jul 15, 2024

Conversation

korenmiklos
Copy link
Member

Summary

  • For introspection, evaluate every function call in Main

Related Issues

Number of Passing Unit Tests

Tests passing: 319/319

Checklist

  • Version number has been bumped in Project.toml

No, let's wait for more bugfixes.

Tests

  • ] test runs without errors
  • Unit tests have been added
  • This is a refactoring, no new tests required

Documentation

  • Documentation has been updated
  • No change to public API, documentation not required

@korenmiklos
Remove an unused test, add 1 failing test for #157
d92ddb3 
315/316 tests pass
@korenmiklos
False alarm, was just using split wrong. wontfix #157
90a740b 
316/316
@korenmiklos
Check in 3 tests for calling functions in other modules
3926fd6 
2 fail, 317/319 pass
@korenmiklos
Introspect function methods in Main scope (#133)
9676aa7 
At compile time, symbols defined in Main are only accessible as Main.symbol. At runtime, we are already in Main, so can be referred to as symbol.

319/319 tests pass
@korenmiklos
Don't even try evaluating in global scope, only in Main (fix #133)
af906a5 
Update docs, Main.function_call() no longer needed

319/319 tests pass
@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Files Coverage Δ
src/commands.jl 94.36% <ø> (ø)
src/codegen.jl 95.34% <94.11%> (+10.99%) ⬆️

@korenmiklos
Copy link
Member Author

  • 325/325 pass
  • this was a bug, no new documentation needed

gergelyattilakiss
gergelyattilakiss requested changes Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@gergelyattilakiss gergelyattilakiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add codegen tests too, to cover get_dot_parts, and operates_on_type functions. We should test the units too and not just the end functionality I guess.

@korenmiklos
Copy link
Member Author

Good point.

@korenmiklos
Copy link
Member Author

@gergelyattilakiss added tests for internal functions, pls check

Also fixed #158 with tests

370/370 tests pass.

@gergelyattilakiss gergelyattilakiss merged commit 26aae12 into main Jul 15, 2024
9 checks passed
@korenmiklos korenmiklos deleted the 0.4-bugfixes branch October 22, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gergelyattilakiss gergelyattilakiss gergelyattilakiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: functions in other modules cannot be used
2 participants
@korenmiklos @gergelyattilakiss