OpenBSD compatibility #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 7, 2014 11:23
|
Is there any possibility of these changes (once updated for 3.28) being merged? Galera has been working well for us on OpenBSD for the last five years. |
|
Seeing the port added recently, it would be nice if this was rebased and commited. Just noticed this is on the 3.x branch. Needs to be updated for the 4.x branch. |
brad0
reviewed
May 14, 2023
| @@ -3,7 +3,7 @@ | |||
| #include "gu_backtrace.h" | |||
| #include "gu_log.h" | |||
|
|
|||
| #ifdef __GNUC__ | |||
| #if defined(__GNUC__) && !defined(__OpenBSD__) | |||
| #include <execinfo.h> | |||
| #include <stdlib.h> | |||
|
|
|||
There was a problem hiding this comment.
This patch should be removed since it is no longer relevant.
| #include <endian.h> | ||
| #define gu_bswap16(x) __swap16(x) | ||
| #define gu_bswap32(x) __swap32(x) | ||
| #define gu_bswap64(x) __swap64(x) | ||
| #elif defined(__sun__) |
There was a problem hiding this comment.
Robert used the swapX macros. Wonder if that makes more sense as they use the bswapX macros further down.
| #endif | ||
| #ifndef EBADMSG | ||
| # define EBADMSG (GU_ELAST+8) | ||
| #endif | ||
|
|
There was a problem hiding this comment.
This patch can be removed as it is no longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some fairly minor changes, galera builds and works on current OpenBSD