Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update garb_config.cpp #641

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Update garb_config.cpp #641

wants to merge 1 commit into from

Conversation

slaptrix
Copy link

@slaptrix slaptrix commented Jun 5, 2023

Added semicolon to line 146 to fix "More than one value for key 'gcs.fc_singele_primary' at 'gcs.fc_single_primary=yes base_dir=...' in parameter list." error.

Added semicolon to line 146 to fix "More than one value for key 'gcs.fc_singele_primary' at 'gcs.fc_single_primary=yes base_dir=...' in parameter list." error.
@ottok
Copy link
Contributor

ottok commented Dec 15, 2024

The git commit message title and message is so bad that I don't think upstream will ever bother to read this or believe you that this is the correct change. Which is sad, because the actual fix is potentially correct.

@slaptrix You might have a better success rate in your open source contributions if you read these and improve how you communicate in git commits/submissions:

@slaptrix
Copy link
Author

The git commit message title and message is so bad that I don't think upstream will ever bother to read this or believe you that this is the correct change. Which is sad, because the actual fix is potentially correct.

@slaptrix You might have a better success rate in your open source contributions if you read these and improve how you communicate in git commits/submissions:

Yeah or i just don't care.
And you know what makes me care even less?
A dude posting his own blog-links as a comment.

@ottok
Copy link
Contributor

ottok commented Dec 16, 2024

It is the same advice as in e.g. https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines, just in a (hopefully) easier to read/digest format.

Capitalized, short (50 chars or less) summary

More detailed explanatory text, if necessary.  Wrap it to about 72
characters or so.  In some contexts, the first line is treated as the
subject of an email and the rest of the text as the body.  The blank
line separating the summary from the body is critical (unless you omit
the body entirely); tools like rebase will confuse you if you run the
two together.

Write your commit message in the imperative: "Fix bug" and not "Fixed bug"
or "Fixes bug."  This convention matches up with commit messages generated
by commands like git merge and git revert.

Further paragraphs come after blank lines.

- Bullet points are okay, too

- Typically a hyphen or asterisk is used for the bullet, followed by a
  single space, with blank lines in between, but conventions vary here

- Use a hanging indent

..but if you don't care, then any help or advice offered to you is still useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants