-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WalletLinkWebSocketUpdateListener #1063
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/wallet-sdk/src/connection/WalletLinkConnection.ts
bangtoven
force-pushed
the
jungho/connection-state-/revisit-connected
branch
2 times, most recently
from
November 14, 2023 06:16
c1b9515
to
b52b24a
Compare
bangtoven
force-pushed
the
jungho/connection-state-/revisit-connected
branch
from
November 14, 2023 06:20
b52b24a
to
093283b
Compare
bangtoven
commented
Nov 14, 2023
Comment on lines
6
to
10
export enum ConnectionState { | ||
DISCONNECTED, | ||
CONNECTING, | ||
CONNECTED, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arbitrary client-side-only concept
bangtoven
changed the title
Jungho/connection state /revisit connected
WalletLinkWebSocketUpdateListener
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test your changes?