fix redirecting on webviews #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fan-zhang-sv
previously approved these changes
Feb 23, 2024
bangtoven
previously approved these changes
Feb 24, 2024
bangtoven
approved these changes
Feb 24, 2024
bangtoven
added a commit
that referenced
this pull request
Feb 29, 2024
* rename the package * Squashed commit of the following: commit 26e68f9f6d1eac389c6329d06e20ca538484522c Author: Jungho Bang <[email protected]> Date: Wed Feb 28 19:27:38 2024 -0700 duh commit 8ce4d4acabf6f1d5419ddd2561446e374ac0dcd7 Author: Jungho Bang <[email protected]> Date: Wed Feb 28 19:20:54 2024 -0700 merge latest public commit f047e9b975d1e92505aedeacb7cc16a4b38b3b3a Merge: 9652bed4 c57516a Author: Jungho Bang <[email protected]> Date: Wed Feb 28 19:19:30 2024 -0700 Merge branch 'master' into jungho/publish-ready # Conflicts: # apps/testapp/package.json # packages/wallet-sdk/package.json # packages/wallet-sdk/src/relay/mobile/MobileRelay.ts # packages/wallet-sdk/src/relay/mobile/MobileRelayUI.ts # packages/wallet-sdk/src/version.ts # yarn.lock commit 9652bed40a5e01fc9aefb7c8d1dac0f3150dd075 Author: Jungho Bang <[email protected]> Date: Wed Feb 28 19:16:08 2024 -0700 move relay ui file for merging commit c57516a Author: Pedro Rosário <[email protected]> Date: Sat Feb 24 01:03:36 2024 -0300 Fix/deeplink from webview for android (#1121) * fix: anchor tag approach to cover both iOS and Android cases * fix: add expected target --------- Co-authored-by: Pedro Rosario <[email protected]> commit 9aba4c2 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri Feb 23 16:20:26 2024 -0800 v3.9.2 (#1120) Co-authored-by: bangtoven <[email protected]> commit db3995e Author: Pedro Rosário <[email protected]> Date: Fri Feb 23 21:17:34 2024 -0300 fix redirecting on webviews (#1119) * fix redirecting on webviews * remove dead code * fix: typecheck --------- Co-authored-by: Pedro Rosario <[email protected]> commit ae895de Author: Jungho Bang <[email protected]> Date: Fri Dec 8 15:18:29 2023 -0500 use 3.9.1 on the test app (#1097) * update yarn.lock * cleanup release script * update license / year * update yarn.lock * cleanup license * Revert "update yarn.lock" This reverts commit 4354e48dbffdb5698e722dbe09c26587dc8d7ace. * fuck * revert to public gha * Revert "revert to public gha" This reverts commit 45ee8551c34de59dd05c95591cef364483754dd4. * update version
bangtoven
added a commit
that referenced
this pull request
Feb 29, 2024
* rename the package * Squashed commit of the following: commit 26e68f9f6d1eac389c6329d06e20ca538484522c Author: Jungho Bang <[email protected]> Date: Wed Feb 28 19:27:38 2024 -0700 duh commit 8ce4d4acabf6f1d5419ddd2561446e374ac0dcd7 Author: Jungho Bang <[email protected]> Date: Wed Feb 28 19:20:54 2024 -0700 merge latest public commit f047e9b975d1e92505aedeacb7cc16a4b38b3b3a Merge: 9652bed4 c57516a Author: Jungho Bang <[email protected]> Date: Wed Feb 28 19:19:30 2024 -0700 Merge branch 'master' into jungho/publish-ready # Conflicts: # apps/testapp/package.json # packages/wallet-sdk/package.json # packages/wallet-sdk/src/relay/mobile/MobileRelay.ts # packages/wallet-sdk/src/relay/mobile/MobileRelayUI.ts # packages/wallet-sdk/src/version.ts # yarn.lock commit 9652bed40a5e01fc9aefb7c8d1dac0f3150dd075 Author: Jungho Bang <[email protected]> Date: Wed Feb 28 19:16:08 2024 -0700 move relay ui file for merging commit c57516a Author: Pedro Rosário <[email protected]> Date: Sat Feb 24 01:03:36 2024 -0300 Fix/deeplink from webview for android (#1121) * fix: anchor tag approach to cover both iOS and Android cases * fix: add expected target --------- Co-authored-by: Pedro Rosario <[email protected]> commit 9aba4c2 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri Feb 23 16:20:26 2024 -0800 v3.9.2 (#1120) Co-authored-by: bangtoven <[email protected]> commit db3995e Author: Pedro Rosário <[email protected]> Date: Fri Feb 23 21:17:34 2024 -0300 fix redirecting on webviews (#1119) * fix redirecting on webviews * remove dead code * fix: typecheck --------- Co-authored-by: Pedro Rosario <[email protected]> commit ae895de Author: Jungho Bang <[email protected]> Date: Fri Dec 8 15:18:29 2023 -0500 use 3.9.1 on the test app (#1097) * update yarn.lock * cleanup release script * update license / year * update yarn.lock * cleanup license * Revert "update yarn.lock" This reverts commit 4354e48dbffdb5698e722dbe09c26587dc8d7ace. * fuck * revert to public gha * Revert "revert to public gha" This reverts commit 45ee8551c34de59dd05c95591cef364483754dd4. * update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Navigating to CB Wallet app deeplink via window.open and not replacing window.href was causing a broken behavior when the SDK is running from inside a webview. This PR replaces the redirecting strategy in order to fix this bug
How did you test your changes?
Manually tested using an RN test app that renders the test dapp from inside a webview
Untitled-ezgif.com-resize-video.1.mp4
Untitled-ezgif.com-resize-video.mp4