Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sdk playground disconnect #1465

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix sdk playground disconnect #1465

merged 1 commit into from
Dec 19, 2024

Conversation

cb-jake
Copy link
Contributor

@cb-jake cb-jake commented Dec 19, 2024 •
edited
Loading

Summary

Fix disconnect in SDK playground

How did you test your changes?

n/a

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 19, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-jake cb-jake merged commit 15eda0e into master Dec 19, 2024
8 checks passed
@cb-jake cb-jake deleted the fix-disconnect branch December 19, 2024 19:28
dropkick1325
dropkick1325 reviewed Dec 23, 2024
View reviewed changes
Copy link

@dropkick1325 dropkick1325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dropkick1325 dropkick1325 dropkick1325 left review comments

@spencerstock spencerstock spencerstock approved these changes

@fan-zhang-sv fan-zhang-sv Awaiting requested review from fan-zhang-sv

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cb-jake @cb-heimdall @spencerstock @dropkick1325