Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"review_state" and "subjects" usable as facet #30

Merged
merged 9 commits into from
Apr 5, 2024

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Apr 2, 2024

Add celery task "deleteindex"

Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if it is fine for you to have the examples/analysis changes in here too. I do not mind. It may need a mention in the change log if it is significant.

adresse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this sneaked in accidentally? This is not mentioned in the change-log...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example configuration with keywords and lexicon, like in tests of @rohberg/volto-searchkit-block

},
"zope.schema._field.URI": {
"type": "text"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.... formatting only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mappings is reorganized and stripped:

  • Text, Textline, subjects with analyzer at the top of the file. Everything else below.
  • No more special "title" configuration, as it is Text

@jensens
Copy link
Member

jensens commented Apr 5, 2024

Just merge this yourself if you think it is ready.

@ksuess ksuess merged commit 1ceef9d into main Apr 5, 2024
10 checks passed
@ksuess ksuess deleted the review_state-to-keyword branch April 5, 2024 10:58
@ksuess
Copy link
Member Author

ksuess commented Apr 19, 2024

@jensens Can we get a release please.

@jensens
Copy link
Member

jensens commented Apr 19, 2024

@jensens Can we get a release please.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants