-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Separate website/elements/apps from library? #434
Comments
Where would the API docs live? Presumably they need access to the source, but perhaps that can be done by installing |
That should work if we want to keep all website stuff together. Alternatively there could also be a Git submodule that links back to this repo, but that might be overcomplicating things. |
Yeah, my opinion on this is that submodules are plague and must be avoided at all costs 😛 |
I’ve been thinking about this and I think it makes sense to also separate apps and elements into separate repos / separate npm packages / separate subdomains. Especially as I plan a bit of a revamp of these, what do you think about separating them? |
As an update, I have split elements and apps into their own repos and websites (https://apps.colorjs.io and https://elements.colorjs.io respectively). The website will be harder to split out though… |
Ok, thinking about this some more, I have a plan:
We will install Thoughts? |
I think it'd be ideal to have tests/benchmarks alongside the source code, but I'm not sure how practical it'd be to host them on the website if we do that. If there's an easy way to set up the website to use content from multiple repositories (besides Git submodules which we've decided against), then I'd opt for putting those directories with the source code. Otherwise I'd say they should go with the rest of the website content. |
Depends on what you mean by "the website". We can easily deploy the code repo to a separate subdomain (e.g. |
That'd be the best way to do it then imo |
The current structure has served us well but we're at the point where we need to separate the two.
In terms of tests, presumably the JS tests will stay with the library, while the HTML tests (old and new) will live with the website.
Both will still deploy to the web, I’m thinking
dev.colorjs.io
for the library repo.The text was updated successfully, but these errors were encountered: