Document how to serve in development, and add --serve to watch:html.
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jgerigmeyer
reviewed
Mar 1, 2024
Co-authored-by: Jonny Gerig Meyer <[email protected]>
jgerigmeyer
approved these changes
Mar 1, 2024
|
Would this cause issues for #434 ? |
|
Ok, fine by me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current npm scripts for development don't include a way to serve the built files. Because 11ty contains a dev server, we can use that.
This adds the
--serveflag tonpm run watch:html(and by extensionnpm run watch) so that developers don't need to separately serve the content.If this is disruptive to existing workflows, we could add an alternate
npm run devthat would watch css, js and html, and also serve. Alternatively, we could document how to serve withnpx http-server, but since the functionality is already available through 11ty, this seems like a higher burden on contributors.