Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set typescript target of ES2018 #586

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

lloydk
Copy link
Collaborator

@lloydk lloydk commented Aug 16, 2024

Typescript 5.5 added support for regular expression syntax checking. One of the checks tests if a regular expression is using features that aren't supported by the target version of ECMAScript.

Named capture groups are used in src/Type.js and possibly some other files so a target of ES2018 was added to tsconfig.json.

let params = type.trim().match(/^(?<type><[a-z]+>)(\[(?<min>-?[.\d]+),\s*(?<max>-?[.\d]+)\])?$/);

Typescript 5.5 add support for regular expression syntax checking.
One of the checks tests if a regular expression is using features
that aren't supported by the target version of ECMAScript.

Named capture groups are used in src/Type.js and possibly some
other files so a target of ES2018 was added to tsconfig.json.
@lloydk lloydk requested a review from MysteryBlokHed August 16, 2024 21:17
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for colorjs ready!

Name Link
🔨 Latest commit bb860c4
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/66bfc1d669bb0b0008e4f4b9
😎 Deploy Preview https://deploy-preview-586--colorjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MysteryBlokHed MysteryBlokHed merged commit f50d95a into color-js:main Aug 20, 2024
5 checks passed
@lloydk lloydk deleted the tsconfig-target branch August 20, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants