Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename page 1 #124

Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore: Rename page 1 #124

merged 1 commit into from
Jun 5, 2024

Conversation

He-Pin
Copy link
Contributor

@He-Pin He-Pin commented May 19, 2024

Motivation:
The current : will cause an issue when checkout on windows.

Modification:
Rename the file name.

Result:
Works fine on Windows when git clone

Motivation: 
The current `:` will cause an issue when checkout on windows.
@He-Pin He-Pin mentioned this pull request May 19, 2024
@He-Pin
Copy link
Contributor Author

He-Pin commented Jun 2, 2024

@lihaoyi Would you like to merge this? I'm using Windows 11 and : is not a valid path.

@lihaoyi lihaoyi merged commit a6719f6 into com-lihaoyi:master Jun 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants