Rework compile time error message for scala 3 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodersky
commented
Nov 2, 2024
build.sc
Outdated
| @@ -33,7 +33,7 @@ import de.tobiasroeser.mill.vcs.version.VcsVersion | |||
|
|
|||
| val scala213 = "2.13.10" | |||
| val scala212 = "2.12.17" | |||
| val scala3 = "3.2.2" | |||
| val scala3 = "3.3.3" | |||
There was a problem hiding this comment.
Not sure why this update is exactly needed.
I ran into a seemingly unrelated error:
[error] error while loading TimeUnit,
[error] class file /modules/java.base/java/util/concurrent/TimeUnit.class is broken, reading aborted with class java.lang.RuntimeException
[error] bad constant pool index: 0 at pos: 3355
which is likely due to me building on a machine with JDK >= 21.
In any case, I think we can bump this since Scala 3.3.x is an LTS anyway.
jodersky
force-pushed
the
jo/error-message
branch
from
8ea6f76 to
21cd0b0
Compare
jodersky
force-pushed
the
jo/error-message
branch
from
21cd0b0 to
bdffffe
Compare
This includes more information in the error message that is generated when a route declaration has an invalid return type.
jodersky
force-pushed
the
jo/error-message
branch
from
bdffffe to
9cdacc8
Compare
jodersky
commented
Nov 2, 2024
| initialize() | ||
| } | ||
| """).msg ==> | ||
| "error in route definition `def hello` (at tasty-reflect:4:15): the method's return type scala.Tuple2[scala.Int, scala.Int] cannot be converted to the expected response type cask.model.Response[cask.model.Response.Data]" |
There was a problem hiding this comment.
Note that the position "tasty-reflect:4:15" is synthetic in this test. I manually verified that the error position is correct on an actual cask project.
lihaoyi
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes more information in the error message that is generated when a route declaration has an invalid return type.
It notably also includes the source position, as discussed in #141.