Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unwrapped underlying subprocess input streams when pumping #3360

Merged
merged 1 commit into from
Aug 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main/api/src/mill/api/SystemStreams.scala
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ object SystemStreams {
private class PumpedProcessInput extends os.ProcessInput {
def redirectFrom = ProcessBuilder.Redirect.PIPE
def processInput(processIn: => os.SubProcess.InputStream): Some[InputPumper] = Some(
new InputPumper(() => System.in, () => processIn, true, () => true)
new InputPumper(() => System.in, () => processIn.wrapped, true, () => true)
)
}

private class PumpedProcessOutput(dest: OutputStream) extends os.ProcessOutput {
def redirectTo = ProcessBuilder.Redirect.PIPE
def processOutput(processOut: => os.SubProcess.OutputStream): Some[InputPumper] =
Some(new InputPumper(() => processOut, () => dest, false, () => true))
Some(new InputPumper(() => processOut.wrapped, () => dest, false, () => true))
}
def withStreams[T](systemStreams: SystemStreams)(t: => T): T = {
val in = System.in
Expand Down