make stream headers accessible in return value of stream method #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #172
Refactors
Resquester.stream()
to return ato make the stream headers directly accessible.
This changes the semantics of
stream()
to immediately perform the request and retrieve the headers. The body is still only retrieved when the stream is consumed.A cleaner approach would probably be to return a tuple. However to avoid a braking change in the API the approach with
ReadableWithStreamHeaders
was chosen.The
onHeadersReceived
can probably be deprecated as it should no longer be needed.