Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

307 remove usage of deprecated set-output command for GitHub Actions #308

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

apupier
Copy link
Member

@apupier apupier commented Feb 3, 2023

fixes #307

@pascalwilbrink pascalwilbrink self-requested a review February 6, 2023 14:34
-Dsonar.projectKey=com-pas_compas-scl-data-service \
-Dsonar.organization=com-pas )"
-Dsonar.organization=com-pas \" >> $GITHUB_OUTPUT
Copy link
Member

@pascalwilbrink pascalwilbrink Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pr 👍

There's a " missing/leftover

-Dsonar.organization=com-pas >> $GITHUB_OUTPUT

Can we help you to fix this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can absolutely modify my Pull Requests when you want if you are a maintainer (I allowed edits to maintainers) or pick my work and start a new branch and PR if not.

@apupier apupier force-pushed the 307-removeUsageOfDeprecatedSetOuput branch 2 times, most recently from b4771b9 to 4ed564c Compare February 22, 2023 13:39
apupier added 2 commits March 3, 2023 14:56
Completely removing the intermediate step calculating the tag_name as
GitHub Actions is now providing this value in the context directly.
See https://github.com/orgs/community/discussions/26686 and
https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

part of com-pas#307

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier force-pushed the 307-removeUsageOfDeprecatedSetOuput branch from 4ed564c to 992a57e Compare March 3, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output in GitHub Actions before 31st May 2023
2 participants