msgq: fix permission of subscribers #636
Open
+64
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes mmap() protection of subscribers from 'PROT_READ | PROT_WRITE' to 'PROT_READ' only. It can prevent data area curruption by unintentional writes from subscribers to shared memory area.
This patch fixes tests of msgq to distinguish between msgq_new_queue() funtions of pub/sub.
|
Seems like it's still easy to setup a subscriber that can write. Can you add a test to ensure that doesn't happen? Or even better, can you think of a way to rewrite it to make that bug less likely? |
|
Thank you for your comment! I'm targeting for 'normal subscribers' that use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of MSGQ and VisionIPC allows subscriber processes to potentially overwrite publisher's data because subscribers have write permissions for shared data area of the queue.
This patch changes mmap() protection of subscribers from
PROT_READ | PROT_WRITEtoPROT_READonly.This prevents unintended writes by subscribers and ensures the integrity of publisher's data.