Skip to content

Commit

Permalink
refactor(Commit): Added deprecation on git signoff mechanic
Browse files Browse the repository at this point in the history
Signoff dedicated code is no longer necessary & removed #TODO as tests show identical args and extra-args are not an issue.
  • Loading branch information
SCrocky committed Nov 26, 2022
1 parent fc81dc8 commit 600f96a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion commitizen/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,6 @@ def main():
raise InvalidCommandArgumentError(
f"Invalid commitizen arguments were found before -- separator: `{' '.join(unknown_args[:pos])}`. "
)
# TODO: treat case when extra-args and commitizen args are identical
extra_args = " ".join(unknown_args[1:])
arguments["extra_cli_args"] = extra_args

Expand Down
1 change: 1 addition & 0 deletions commitizen/commands/commit.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ def __call__(self):
signoff: bool = self.arguments.get("signoff")

if signoff:
out.warn("signoff mechanic is deprecated, please use `cz commit -- -s` instead.")
c = git.commit(m, "-s")

if self.arguments.get("extra_cli_args"):
Expand Down

0 comments on commit 600f96a

Please sign in to comment.