-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commands/commit): add manual-edit functionality after answering questions #1262
feat(commands/commit): add manual-edit functionality after answering questions #1262
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
==========================================
+ Coverage 97.33% 97.61% +0.27%
==========================================
Files 42 55 +13
Lines 2104 2602 +498
==========================================
+ Hits 2048 2540 +492
- Misses 56 62 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
30409a4
to
9898d3e
Compare
.../commands/test_commit_command/test_commit_command_shows_description_when_use_help_option.txt
Show resolved
Hide resolved
0142443
to
9b42049
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one nit, but mostly looks good!
…uestions refactor: remove redundant return None Co-authored-by: Wei Lee <[email protected]> Update test_commit_command.py Co-authored-by: Wei Lee <[email protected]>
f73d452
to
513f86a
Compare
Description
Add one argument
-e/--edit
to commit command, to allow user to continue editing after filling up all the questions.(Kudos to @MrMino! The
pytest-edit
project inspired me to come up with this idea.)Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
if
-e/--edit
enabled, the terminal would pop up editor with commit message after finishing the answering.Steps to Test This Pull Request
cz c -e