Make leading/trailing spaces optional in templating #792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Allow templating in granted config file to contain lead/trailing spaces or not at all.
Why?
The usage of templating in granted config files is more forgiving if the author doesn't have spaces in their go templating syntax. Without this it's unclear why template syntax is left un-rendered in the AWS config file.
How did you test it?
Built CLI and tested using a registry containing a test profile config and granted config file:
Test profile config
Test granted config
Add test registry
Observe rendered profiles
Potential risks
There shouldn't be risks given that the updated regular expression allows for zero or more spaces, which should be backwards compatible with all existing usages.
Is patch release candidate?
Link to relevant docs PRs
N/A