Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Fix CTK PluginFramework library build #1147

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Oct 25, 2023

Follow-up c0c8e41 (ENH: Improve setting of CTK_QT5_COMPONENTS based on actual requirements) fixing the check adding Sql to the list of components when CTK_ENABLE_PluginFramework

Before

$ cmake \
  -DCTK_ENABLE_PluginFramework:BOOL=ON \
  -DCMAKE_BUILD_TYPE:STRING=Release \
  -DQt5_DIR:PATH=$Qt5_DIR -DCTK_QT_VERSION:STRING=5 \
  ../CTK

[...]
-- Configuring CTK with Qt 5.15.2 (using modules: Core, Concurrent, Test, Designer)
-- SuperBuild - First pass
-- SuperBuild - First pass - done
[...]
-- SuperBuild - CTK[OK]
-- Configuring done (2.9s)
-- Generating done (0.0s)

After

$ rm -rf *
$ cmake \
  -DCTK_ENABLE_PluginFramework:BOOL=ON \
  -DCMAKE_BUILD_TYPE:STRING=Release \
  -DQt5_DIR:PATH=$Qt5_DIR -DCTK_QT_VERSION:STRING=5 \
  ../CTK

[...]
-- Configuring CTK with Qt 5.15.2 (using modules: Core, Concurrent, Sql, Test, Designer)
-- SuperBuild - First pass
-- SuperBuild - First pass - done
[...]
-- SuperBuild - CTK[OK]
-- Configuring done (2.9s)
-- Generating done (0.0s)

Follow-up c0c8e41 (ENH: Improve setting of CTK_QT5_COMPONENTS based
on actual requirements) fixing the check adding Sql to the list of
components when CTK_ENABLE_PluginFramework

Reported-by: XXOO9 <[email protected]>
@jcfr jcfr linked an issue Oct 25, 2023 that may be closed by this pull request
@jcfr jcfr enabled auto-merge (rebase) October 25, 2023 18:34
@jcfr jcfr merged commit 8e536f2 into master Oct 25, 2023
2 checks passed
@jcfr jcfr deleted the fix-setting-of-qt-required-components branch October 25, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Build Problem
1 participant