Fix DICOM tests and update ctkFileDialog to consider AA_DontUseNativeDialogs attribute
#1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the test to account for change in `ctkDICOMTagCache` now internally storing tag as uppercase hex. See 8418771 ("ENH: Update DICOM Database with URL Support and Tag Cache Optimization", 2023-12-13)
… default This commit addresses connectivity problems with the "dicomserver.co.uk" server, specifically resolving issues encountered running `ctkDICOMDemoSCUTest1`. Additionally, it updates the default port in `ctkDICOMServerNodeWidget` and documents the change in the `ctkDICOMQuery` docstring. Co-authored-by: Andras Lasso <[email protected]>
…tiveDialogs Follow-up of c4f1eee ("ENH: Update ctkFileDialog to use native dialog by default", 2021-06-10).
Fixes ctkDICOMAppWidgetTest1 adding a the attribute ctkDICOMAppWidget::CopyOnImport allowing to configure the import mode. Co-authored-by: Davide Punzo <[email protected]>
Switch to use of QCommandLineParser to ensure the "-I" is properly parsed independently of the order of the command line argument. Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
Follow-up of c4f1eee ("ENH: Update ctkFileDialog to use native dialog by default", 2021-06-10). Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
jcfr
commented
Jan 13, 2024
Comment on lines
+148
to
+151
| if (QGuiApplication::testAttribute(Qt::AA_DontUseNativeDialogs)) | ||
| { | ||
| this->setOptions(QFileDialog::DontUseNativeDialog); | ||
| } |
This was referenced Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the following tests can be executed after installing CTK into
<CTK-top-level-build>/CMakeExternals/Install/:ctkDICOMAppWidgetTest1ctkDICOMDatabaseTest2ctkDICOMBrowserTesterIt also updates
ctkFileDialogto ensure it considers application attributeAA_DontUseNativeDialogs.