Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update front end accessibility #735

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

theimbender
Copy link
Contributor

@theimbender theimbender commented Sep 24, 2023

This update provides a few tweaks to the front end view that should get the Lighthouse accessibility score to 100:

  • Update NPM dependencies
  • Include all of Bootstrap instead of just trying to comment out what's not used. Since PurgeCSS was added to the project to remove unused styles in Update front end dependencies, purge unused CSS from bundle #730, we don't have to do that manually and it just makes it harder if you're trying to use parts of Bootstrap that would need to be re-added
  • Change how the collapsible sections work, since I had it backwards when I first implemented ARIA. This change puts aria-expanded on the control rather than container element, and adds aria-controls to support the relationship between control and container.
  • Use the hidden property to prevent collapsed sections from being tabbed to
  • Add a debounced listener to window resize event to update the heights of collapsed sections on window resizes
  • Add aria-label attribute to select elements with no associated label
  • Update some CSS class names, Bootstrap has classes that specifically add good text color contrast that we should be taking advantage of
  • Update the link icon next to each package's title to be the same color as the link text so that it's visible

@theimbender theimbender force-pushed the feature-frontend-updates branch from 7c26ea7 to fcc6956 Compare September 24, 2023 20:54
@alcohol alcohol force-pushed the feature-frontend-updates branch from fcc6956 to 88f6d99 Compare September 25, 2023 12:12
@theimbender theimbender force-pushed the feature-frontend-updates branch 4 times, most recently from 9dd45d9 to d12cf68 Compare September 26, 2023 23:03
@alcohol alcohol force-pushed the feature-frontend-updates branch from d12cf68 to aca388b Compare October 2, 2023 08:32
@alcohol alcohol enabled auto-merge (rebase) October 2, 2023 08:32
@alcohol alcohol merged commit 54b4e5c into composer:main Oct 2, 2023
9 checks passed
@alcohol
Copy link
Member

alcohol commented Oct 2, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants