Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File internals that work directly with Path #2869

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add File internals that work directly with Path #2869

wants to merge 23 commits into from

Conversation

adithyaov
Copy link
Member

No description provided.

@adithyaov adithyaov force-pushed the file-open-direct branch 4 times, most recently from 9ffc75b to da8093e Compare October 29, 2024 12:07
@adithyaov adithyaov linked an issue Oct 30, 2024 that may be closed by this pull request
Use the Path type in the File module #2770
Open
@adithyaov
Copy link
Member Author

Ensure the change made is tested in the CIs

@adithyaov adithyaov force-pushed the file-open-direct branch 2 times, most recently from a48ea71 to c91d3f6 Compare November 4, 2024 11:32
harendra-kumar
harendra-kumar requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@harendra-kumar harendra-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the module names as follows:

FileSystem.Windows.File => FileSystem.File.Window
FileSystem.Posix.File => FileSystem.File.Posix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harendra-kumar harendra-kumar harendra-kumar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the Path type in the File module
2 participants
@adithyaov @harendra-kumar