Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Department tours pt2 #201

Merged
merged 27 commits into from Dec 22, 2021
Merged

Department tours pt2 #201

merged 27 commits into from Dec 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2020

This is the department tours form. I made a new pull request because I messed up the commits in the last request. This one should contain only the department tour form.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 25, 2020

This pull request introduces 8 alerts when merging 1cd9483 into 95adf85 - view on LGTM.com

new alerts:

  • 7 for Unused import
  • 1 for 'import *' may pollute namespace

@ghost ghost linked an issue Mar 25, 2020 that may be closed by this pull request
@ghost
Copy link
Author

ghost commented Mar 25, 2020

Also, not really sure how to send emails (currently it's commented out of my code). This is the error that comes up when I try decrypting secrets.py.gpg
Screen Shot 2020-03-25 at 4 11 52 PM

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 26, 2020

This pull request introduces 8 alerts when merging 1dae8d1 into 95adf85 - view on LGTM.com

new alerts:

  • 7 for Unused import
  • 1 for 'import *' may pollute namespace

Copy link
Member

@jvperrin jvperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments, but mostly looks good to me

hknweb/admin.py Outdated Show resolved Hide resolved
hknweb/models.py Outdated Show resolved Hide resolved
hknweb/templates/base.html Outdated Show resolved Hide resolved
hknweb/templates/base.html Outdated Show resolved Hide resolved
hknweb/tours/migrations/0001_initial.py Outdated Show resolved Hide resolved
hknweb/tours/views.py Outdated Show resolved Hide resolved
hknweb/views/landing.py Outdated Show resolved Hide resolved
Pipfile.lock Outdated Show resolved Hide resolved
hknweb/tours/views.py Outdated Show resolved Hide resolved
hknweb/tours/views.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 26, 2020

This pull request introduces 4 alerts when merging 4046aad into 95adf85 - view on LGTM.com

new alerts:

  • 4 for Unused import

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 23, 2020

This pull request introduces 1 alert when merging b6cb97e into 478bc33 - view on LGTM.com

new alerts:

  • 1 for Unused import

@bri25yu
Copy link
Contributor

bri25yu commented Dec 22, 2021

Merged this with master to merge this PR in :)) Thanks for your work Connie!!

@bri25yu bri25yu closed this Dec 22, 2021
@bri25yu bri25yu reopened this Dec 22, 2021
@bri25yu bri25yu merged commit f18954c into compserv:master Dec 22, 2021
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 22, 2021

This pull request introduces 1 alert when merging e34f163 into f8e3857 - view on LGTM.com

new alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprel Admin (department tours)
2 participants