Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Properly define custom <LIB>_FOUND in CMakeDeps generators of several recipes #12954

Open
SpaceIm opened this issue Sep 14, 2022 · 1 comment
Open

[bug] Properly define custom <LIB>_FOUND in CMakeDeps generators of several recipes #12954

SpaceIm opened this issue Sep 14, 2022 · 1 comment

Comments

@SpaceIm
Copy link
Contributor

SpaceIm commented Sep 14, 2022 •
edited
Loading

I open an issue to not lost this comment: #12838 (comment)

These recipes should be fixed to properly define their custom <LIB>_FOUND CMake variable in CMakeDeps generator:

recipe PR
bzip2 #12840
freetype #13822
jasper #13285
libgeotiff #13665
libxml2 #14427
openal #12841
openssl #12838
xz_utils #13038

If they are not fixed, any recipe migrating to CMakeToolchain & CMakeDeps, and depending on one of these libraries may fail (or worse, silently disable a feature and not honor an option).
@SpaceIm SpaceIm mentioned this issue Oct 11, 2022
Merged
4 tasks
@jngrb
Copy link
Contributor

jngrb commented Nov 25, 2022

PR #12838 only addresses the OpenSSL 1.x.x recipe.

I made similar contributions to the 3.x.x recipe in PR #14426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jngrb @SpaceIm