Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jasper] Add version 3.0.6 and cross-support Conan v1 and v2 #13285

Merged
merged 21 commits into from
Dec 21, 2022

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Oct 3, 2022

Specify library name and version: jasper/3.0.6

  • Removed old versions < 2.0.33
  • Add version 3.0.6
  • Add Conan support
  • Transfer replace_in_file to patch files
  • Validate Conan 1.x with test_v1_package

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Oct 3, 2022

I detected other pull requests that are modifying jasper/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Oct 3, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Hooks produced the following warnings for commit 5bb6d1a
jasper/3.0.6
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libjasper.so' links to system library 'pthread' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@madwax
Copy link

madwax commented Dec 17, 2022

What's going on with this? I'm able to use opencv/4.5.5 under visual studio 2022 but when I move to 2019 and try to install I get a message to this issue?

@HappySeaFox
Copy link
Contributor

@madwax Please vote for #13159 . This is the reason why jasper has this raise line.

czoido
czoido previously approved these changes Dec 20, 2022
jcar87
jcar87 previously approved these changes Dec 20, 2022
tc.variables["JAS_ENABLE_SHARED"] = self.options.shared
tc.variables["JAS_LIBJPEG_REQUIRED"] = "REQUIRED"
tc.variables["JAS_ENABLE_OPENGL"] = False
tc.variables["JAS_ENABLE_LIBJPEG"] = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is already true, but it's good to express it here 👍


def package_info(self):
self.cpp_info.set_property("cmake_find_mode", "both")
self.cpp_info.set_property("cmake_file_name", "Jasper")
self.cpp_info.set_property("cmake_target_name", "Jasper::Jasper")
self.cpp_info.set_property("cmake_build_modules", [self._module_file_rel_path])
self.cpp_info.set_property("pkg_config_name", "jasper")
self.cpp_info.libs = ["jasper"]
if self.settings.os in ["Linux", "FreeBSD"]:
self.cpp_info.system_libs.extend(["m", "pthread"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pthread is a special library - gcc has a flag for it (looking into this..)

Copy link
Contributor

@SpaceIm SpaceIm Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a private dependendency I think, no need for the compilation flag. This block could even be omitted when jasper is shared.

Adopt a workaround provided by @jcar87, which is a temporary
hotfix until having conan-io#13159
fixed.

Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries dismissed stale reviews from jcar87 and czoido via bb7f014 December 21, 2022 10:22
czoido
czoido previously approved these changes Dec 21, 2022
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 26 (00308371fcc4cacbb140d0aaebc4627a37011d4b):

  • jasper/2.0.33@:
    All packages built successfully! (All logs)

  • jasper/3.0.6@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge)

Failure in build 21 (00308371fcc4cacbb140d0aaebc4627a37011d4b):

  • jasper/2.0.33@:
    Didn't run or was cancelled before finishing

  • jasper/3.0.6@:
    CI failed to create some packages (All logs)

    Logs for packageID null:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    ********************************************************************************
    conan install --require=jasper/3.0.6@#ee787e45b1cdc2611d687724a6d61b70 --build=jasper/3.0.6 -pr:h /home/conan/w/prod-v2/BuildSingleReference/5903/b51317cf-9dd6-490a-975f-74174afaad96/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt -c:h tools.system.package_manager:mode=install -c:h tools.system.package_manager:sudo=True -pr:b /home/conan/w/prod-v2/BuildSingleReference/5903/b51317cf-9dd6-490a-975f-74174afaad96/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt -c:b tools.system.package_manager:mode=install -c:b tools.system.package_manager:sudo=True
    ********************************************************************************
    
    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    
    -------- Computing dependency graph --------
    libjpeg/9e: Not found in local cache, looking in remotes...
    libjpeg/9e: Checking remote: conan-center-v2
    libjpeg/9e: Checking remote: c3i_PR-v2-13285
    Graph root
        virtual
    Requirements
        jasper/3.0.6#ee787e45b1cdc2611d687724a6d61b70 - Cache
    Graph error
        Package 'libjpeg/9e' not resolved: Unable to find 'libjpeg/9e' in remotes
    
    -------- Computing necessary packages --------
    ERROR: Package 'libjpeg/9e' not resolved: Unable to find 'libjpeg/9e' in remotes
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants