-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jasper] Add version 3.0.6 and cross-support Conan v1 and v2 #13285
[jasper] Add version 3.0.6 and cross-support Conan v1 and v2 #13285
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying jasper/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 5bb6d1ajasper/3.0.6
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
70177d4
to
69e29ab
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
What's going on with this? I'm able to use opencv/4.5.5 under visual studio 2022 but when I move to 2019 and try to install I get a message to this issue? |
tc.variables["JAS_ENABLE_SHARED"] = self.options.shared | ||
tc.variables["JAS_LIBJPEG_REQUIRED"] = "REQUIRED" | ||
tc.variables["JAS_ENABLE_OPENGL"] = False | ||
tc.variables["JAS_ENABLE_LIBJPEG"] = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is already true, but it's good to express it here 👍
|
||
def package_info(self): | ||
self.cpp_info.set_property("cmake_find_mode", "both") | ||
self.cpp_info.set_property("cmake_file_name", "Jasper") | ||
self.cpp_info.set_property("cmake_target_name", "Jasper::Jasper") | ||
self.cpp_info.set_property("cmake_build_modules", [self._module_file_rel_path]) | ||
self.cpp_info.set_property("pkg_config_name", "jasper") | ||
self.cpp_info.libs = ["jasper"] | ||
if self.settings.os in ["Linux", "FreeBSD"]: | ||
self.cpp_info.system_libs.extend(["m", "pthread"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pthread
is a special library - gcc has a flag for it (looking into this..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a private dependendency I think, no need for the compilation flag. This block could even be omitted when jasper is shared.
Adopt a workaround provided by @jcar87, which is a temporary hotfix until having conan-io#13159 fixed. Signed-off-by: Uilian Ries <[email protected]>
Conan v1 pipelineAll green in build 26 (
Conan v2 pipeline (informative, not required for merge)Failure in build 21 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Specify library name and version: jasper/3.0.6