docs: Create a subfolder for "adding packages" #13736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prince-chrismc
commented
Oct 24, 2022
| @@ -36,14 +36,16 @@ You can follow the three steps (:one: :two: :three:) described below! :tada: | |||
|
|
|||
| :one: The first step to add packages to ConanCenter is requesting access. To enroll in ConanCenter repository, please write a comment | |||
| requesting access in this GitHub [issue](https://github.com/conan-io/conan-center-index/issues/4). Feel free to introduce yourself and | |||
| your motivation to join ConanCenter. | |||
| your motivation to join ConanCenter community. | |||
There was a problem hiding this comment.
This section is for clarity
prince-chrismc
commented
Oct 24, 2022
| @@ -1,13 +1,13 @@ | |||
| # conandata.yml | |||
|
|
|||
| [conandata.yml](https://docs.conan.io/en/latest/reference/config_files/conandata.yml.html) is a [YAML](https://yaml.org/) file to provide declarative data for the recipe (which is imperative). | |||
| [conandata.yml](https://docs.conan.io/en/latest/reference/config_files/conandata.yml.html) is a [YAML](https://yaml.org/) | |||
There was a problem hiding this comment.
this section is for clarity
prince-chrismc
commented
Oct 24, 2022
|
|
||
| ```python | ||
| def package_id(self): | ||
| self.info.header_only() | ||
| self.info.clear() |
prince-chrismc
commented
Oct 24, 2022
| def _configure_cmake(self): | ||
| cmake = CMake(self) | ||
| cmake.definitions['BUILD_TESTING'] = not self.conf.get("tools.build:skip_test", default=true, check_type=bool) | ||
| def generate(self): |
prince-chrismc
commented
Oct 24, 2022
prince-chrismc
commented
Oct 24, 2022
10 tasks
prince-chrismc
commented
Oct 24, 2022
MartinDelille
suggested changes
Oct 24, 2022
uilianries
previously approved these changes
Oct 26, 2022
grafikrobot
reviewed
Oct 28, 2022
grafikrobot
reviewed
Oct 28, 2022
grafikrobot
reviewed
Oct 28, 2022
Conan v1 pipeline |
SSE4
previously approved these changes
Nov 2, 2022
|
More merge conflicts 🙃 |
SSE4
approved these changes
Nov 15, 2022
danimtb
approved these changes
Nov 15, 2022
|
I dont know how I commented on the wrong PR 😖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs!
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
This is towards #13673 where I outlines the goals, the big take away is everything about writing recipes should be in this one folder. no more scattered docs hiding in the faqs for examples.
The main focus of this PR is taking the existing files and moving them. This will make the next set of changes "easier" to review". There are some changes: