Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencv/2.x: Update dependencies #14281

Closed

Conversation

prince-chrismc
Copy link
Contributor

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

Trying to see how bad #13988 is


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Nov 18, 2022

I detected other pull requests that are modifying opencv/2.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@conan-center-bot conan-center-bot added Bump dependencies Only bumping dependencies versions in the recipe Failed labels Nov 18, 2022
@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Nov 18, 2022
4 tasks
prince-chrismc pushed a commit to prince-chrismc/conan-center-index that referenced this pull request Nov 19, 2022
conan-center-bot pushed a commit that referenced this pull request Dec 2, 2022
* jasper: Bump dependencies

Needed for #13988 and #14281

* block failing config + update imports

* fix extra del

* tix typo

* update save to new helper

* Update recipes/jasper/all/conanfile.py

Co-authored-by: SpaceIm <[email protected]>

Co-authored-by: SpaceIm <[email protected]>
@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor Author

prince-chrismc commented Dec 14, 2022

Failure in build 3 (d1b8ad7):

  • opencv/2.4.13.7@:
    Do not raise ConanInvalidConfiguration from build() method. Please, move that same check to validate() method.

The error message is super misleading

https://c3i.jfrog.io/c3i/misc/logs/pr/14281/3-configs/windows-visual_studio/opencv/2.4.13.7//18d96ff8fbeed0cc785be3719208fdd5a06bbe96-build.txt

image

@prince-chrismc
Copy link
Contributor Author

#14754

@prince-chrismc prince-chrismc added the infrastructure Waiting on tools or services belonging to the infra label Dec 20, 2022
@AbrilRBS
Copy link
Member

This looks to be a subset from the changes in #13406 that @SpaceIm seems to have almost ready for 2.0 compatibility, right?

@prince-chrismc
Copy link
Contributor Author

prince-chrismc commented Dec 21, 2022

Most certainly does look that way, this is mostly to unblock the conflicts with zlib but I am surprised that PR is passing 🤔 of maybe #13285 was merged?

EDIT: It was https://github.com/conan-io/conan-center-index/pull/13285/files#diff-f6124e4b428a345d887d0178c50458fbdf98abb78cd99f42879646a252686d73L65

@prince-chrismc prince-chrismc removed the infrastructure Waiting on tools or services belonging to the infra label Dec 21, 2022
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 4 (d1b8ad7ddc5b7de12b7c2674947a5ba6285e8462):

  • opencv/2.4.13.7@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge)

Failure in build 4 (d1b8ad7ddc5b7de12b7c2674947a5ba6285e8462):

  • opencv/2.4.13.7@:
    Error running command conan export --name opencv --version 2.4.13.7 recipes/opencv/2.x/conanfile.py:
    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-14281/recipes/opencv/2.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-14281/recipes/opencv/2.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-14281/recipes/opencv/2.x/conanfile.py", line 2, in <module>
        from conans import ConanFile, CMake, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit d1b8ad7
opencv/2.4.13.7
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413.dll' links to system library 'msvfw32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413.dll' links to system library 'avifil32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413d.dll' links to system library 'avifil32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413d.dll' links to system library 'msvfw32' but it is not in cpp_info.system_libs.

@prince-chrismc
Copy link
Contributor Author

closing in favor of #13406 since I dont want to update the imports :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump dependencies Only bumping dependencies versions in the recipe Failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants