docs: update picking sources and unify with patching rules #14377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: prince-chrismc <[email protected]>
10 tasks
SSE4
reviewed
Nov 23, 2022
SSE4
reviewed
Nov 23, 2022
SSE4
reviewed
Nov 23, 2022
SSE4
reviewed
Nov 23, 2022
SSE4
reviewed
Nov 23, 2022
SSE4
reviewed
Nov 23, 2022
| they change the behavior of the library and it will no longer match the | ||
| documentation or the changelog originally delivered by the authors. | ||
|
|
||
| However, ConanCenter DOES accept **working software patches**, these patches |
There was a problem hiding this comment.
maybe, working software needs some strict definition. as it might be too subjective what is considered working or non-working.
There was a problem hiding this comment.
I agree -- I think it's worth revisiting this to more accurately capture the types of patches we have been seeing since this policy came out :)
SSE4
reviewed
Nov 23, 2022
|
|
||
| ## Policy about patching | ||
|
|
||
| The main guideline in ConanCenter is to provide already compiled binaries for a set of architectures in the least surprising way as possible, so Conan |
There was a problem hiding this comment.
I believe, least surprising way needs some strict definition. it's not clear for newcomer what exactly does it mean.
franramirez688
previously approved these changes
Nov 23, 2022
Co-authored-by: Francisco Ramírez <[email protected]> Co-authored-by: SSE4 <[email protected]>
franramirez688
approved these changes
Nov 24, 2022
uilianries
approved these changes
Nov 25, 2022
prince-chrismc
pushed a commit
to prince-chrismc/conan-center-index
that referenced
this pull request
Nov 29, 2022
conan-center-bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
* cleanup patches from #14377 * subfolder dont exist with new generators * styling is not enforced * move attribute to new home + fix FAQ spelling * delete out date CMake docs from older generators * move test package docs * delete empty file :) * fix links * wording + remove duplicated sections * improve mention of future work * [docs] Regenerate tables of contents Co-authored-by: prince-chrismc <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: prince-chrismc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs!
This is the next installment of #13673 -- it's a bit bigger as I've improved some of the language trying to reflect what's currently happening in CCI
I did not touch the patching rules and exceptions as those deserve their own PR I will not accept suggestions to those please make a seperate PR 🙏