openssl: fix libdir for Android #15483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building libcurl it cannot find lcrypto and lssl because they installed over lib64 and not lib.
This comment has been minimized.
This comment has been minimized.
|
Here is the log with the error without the fix added in this PR: conan install libcurl/7.87.0@ -pr:b default -pr:h android --build missingAnd here the config.log from libcurl cat /root/.conan/data/libcurl/7.87.0/_/_/build/a08ea9e1dd879beff551ed2dd7864467a6dababf/build-release/config.log |
ghost
mentioned this pull request
|
I detected other pull requests that are modifying openssl/1.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
ghost
mentioned this pull request
3 tasks
|
@uilianries @danimtb @RubenRBS @SpaceIm @prince-chrismc could help me to understand what is the error in the Conan v1 pipeline, build 1? |
uilianries
previously approved these changes
Jan 27, 2023
|
@kletoz It should be an internal error, like bad networking. I just restart the CI job. Thank you for reporting us! |
@kletoz Do you have an associated issue or a build log which can prove that error? It would be nice to illustrate for future cases. Could you please paste here your build log error? |
@uilianries The logs I posted here #15483 (comment) have the build error. |
prince-chrismc
previously approved these changes
Jan 27, 2023
SpaceIm
suggested changes
Jan 27, 2023
Is it safe for all? I was trying to follow the previous pattern for Linux. |
Yes it is safe for all, it must be |
Co-authored-by: SpaceIm <[email protected]>
kletoz
dismissed stale reviews from prince-chrismc and uilianries
via
7b1fa82
Co-authored-by: SpaceIm <[email protected]>
|
@SpaceIm could you help me to understand why |
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
SpaceIm
approved these changes
Feb 1, 2023
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
* Fix libdir for Android When building libcurl it cannot find lcrypto and lssl because they installed over lib64 and not lib. * Update recipes/openssl/1.x.x/conanfile.py Co-authored-by: SpaceIm <[email protected]> * Update recipes/openssl/1.x.x/conanfile.py Co-authored-by: SpaceIm <[email protected]> --------- Co-authored-by: SpaceIm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: openssl/1.x.x
When building libcurl it cannot find lcrypto and lssl because they installed over lib64 and not lib.