Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readosm: conan v2 support #16187

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 20, 2023

Specify library name and version: lib/1.0


@conan-center-bot

This comment has been minimized.

jwillikers
jwillikers previously approved these changes Mar 3, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (47efa240d39a5e74b7b02cbe15702ea85215145d):

  • readosm/1.1.0a@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 4 (47efa240d39a5e74b7b02cbe15702ea85215145d):

  • readosm/1.1.0a@:
    All packages built successfully! (All logs)

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 6, 2023

@prince-chrismc do you know why this PR is not displayed in prince-chrismc/conan-center-index-pending-review#1?

@conan-center-bot conan-center-bot requested a review from danimtb April 6, 2023 11:59
@prince-chrismc
Copy link
Contributor

prince-chrismc commented Apr 6, 2023

No I do not :( It's there now so I dont get to investigate

#16187 SpaceIm Feb 20 📝 readosm L 2 Apr 6   jwillikers
#16187 SpaceIm Feb 20 📝 readosm L 2 Apr 6 jwillikers

there's nothing obvious that should have excluded it.

I made https://github.com/prince-chrismc/conan-center-index-pending-review/blob/bb0bdea99c4133092a6299b4a1e0f765df01a8f3/cmd/cpr/main.go#L28 recently so if you are brave you can run this applet and check it

Hopefully we catch this in the future so I can fix whatever bug there might be

@prince-chrismc
Copy link
Contributor

@prince-chrismc
Copy link
Contributor

Ohh derp... The Assumption is that if there was a review (i.e comments or request changes) that person would follow up quickly enough and approve.

Because jordans first review was dismissed it was a non-zero (it will post no reviews) but there was no approvals so it was disgarded


https://api.github.com/repos/conan-io/conan-center-index/pulls/16187/reviews

[
  {
    "id": 1323937342,
    "node_id": "PRR_kwDODDMJAM5O6a4-",
    "user": {
      "login": "jwillikers",
      "id": 19399197,
      "node_id": "MDQ6VXNlcjE5Mzk5MTk3",
      "avatar_url": "https://avatars.githubusercontent.com/u/19399197?u=dac900db43788310516c636d63cd9245b37b51a9&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jwillikers",
      "html_url": "https://github.com/jwillikers",
      "followers_url": "https://api.github.com/users/jwillikers/followers",
      "following_url": "https://api.github.com/users/jwillikers/following{/other_user}",
      "gists_url": "https://api.github.com/users/jwillikers/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jwillikers/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jwillikers/subscriptions",
      "organizations_url": "https://api.github.com/users/jwillikers/orgs",
      "repos_url": "https://api.github.com/users/jwillikers/repos",
      "events_url": "https://api.github.com/users/jwillikers/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jwillikers/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "DISMISSED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/16187#pullrequestreview-1323937342",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16187",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/16187#pullrequestreview-1323937342"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16187"
      }
    },
    "submitted_at": "2023-03-03T14:36:58Z",
    "commit_id": "d242bc7a59e64a83e45f9cf84b520de97c48619f"
  },
  {
    "id": 1374813738,
    "node_id": "PRR_kwDODDMJAM5R8f4q",
    "user": {
      "login": "jwillikers",
      "id": 19399197,
      "node_id": "MDQ6VXNlcjE5Mzk5MTk3",
      "avatar_url": "https://avatars.githubusercontent.com/u/19399197?u=dac900db43788310516c636d63cd9245b37b51a9&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/jwillikers",
      "html_url": "https://github.com/jwillikers",
      "followers_url": "https://api.github.com/users/jwillikers/followers",
      "following_url": "https://api.github.com/users/jwillikers/following{/other_user}",
      "gists_url": "https://api.github.com/users/jwillikers/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/jwillikers/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/jwillikers/subscriptions",
      "organizations_url": "https://api.github.com/users/jwillikers/orgs",
      "repos_url": "https://api.github.com/users/jwillikers/repos",
      "events_url": "https://api.github.com/users/jwillikers/events{/privacy}",
      "received_events_url": "https://api.github.com/users/jwillikers/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "APPROVED",
    "html_url": "https://github.com/conan-io/conan-center-index/pull/16187#pullrequestreview-1374813738",
    "pull_request_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16187",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/conan-io/conan-center-index/pull/16187#pullrequestreview-1374813738"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16187"
      }
    },
    "submitted_at": "2023-04-06T12:57:34Z",
    "commit_id": "47efa240d39a5e74b7b02cbe15702ea85215145d"
  }
]

@conan-center-bot conan-center-bot merged commit 1643800 into conan-io:master Apr 6, 2023
@SpaceIm SpaceIm deleted the readosm-conan-v2 branch April 6, 2023 20:55
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Apr 7, 2023
MartinDelille pushed a commit to MartinDelille/conan-center-index that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants