-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readosm: conan v2 support #16187
readosm: conan v2 support #16187
Conversation
This comment has been minimized.
This comment has been minimized.
d242bc7
to
47efa24
Compare
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 4 (
|
@prince-chrismc do you know why this PR is not displayed in prince-chrismc/conan-center-index-pending-review#1? |
No I do not :( It's there now so I dont get to investigate
there's nothing obvious that should have excluded it. I made https://github.com/prince-chrismc/conan-center-index-pending-review/blob/bb0bdea99c4133092a6299b4a1e0f765df01a8f3/cmd/cpr/main.go#L28 recently so if you are brave you can run this applet and check it Hopefully we catch this in the future so I can fix whatever bug there might be |
Confused I actually can check 😱 |
Ohh derp... The Assumption is that if there was a review (i.e comments or request changes) that person would follow up quickly enough and approve. Because jordans first review was dismissed it was a non-zero (it will post no reviews) but there was no approvals so it was disgarded https://api.github.com/repos/conan-io/conan-center-index/pulls/16187/reviews
|
Specify library name and version: lib/1.0