Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draco/1.4.3 #7843

Merged
merged 10 commits into from
Oct 29, 2021
Merged

draco/1.4.3 #7843

merged 10 commits into from
Oct 29, 2021

Conversation

lederernc
Copy link
Contributor

@lederernc lederernc commented Oct 26, 2021 •
edited
Loading

Fixes #7646

Specify library name and version: draco/1.43 and draco/1.4.1 and draco/1.4.0

I saw this issue and decided to try and address it while working on getting versions 1.3.5 and 1.3.6 to work with gcc-11

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@prince-chrismc prince-chrismc mentioned this pull request Oct 26, 2021
Open
danimtb
danimtb reviewed Oct 27, 2021
View reviewed changes
recipes/draco/config.yml Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@danimtb danimtb changed the title Conan io#7646 draco/1.4.3 Oct 28, 2021
This was referenced Oct 28, 2021
Open
Closed
@conan-center-bot
Copy link
Collaborator

All green in build 6 (7c8bb948b56d3175b9a097263be3a6df6fcff965):

  • draco/1.4.3@:
    All packages built successfully! (All logs)

  • draco/1.3.5@:
    All packages built successfully! (All logs)

  • draco/1.3.6@:
    All packages built successfully! (All logs)

SSE4
SSE4 approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

draco-malfoy

@conan-center-bot conan-center-bot merged commit 1021488 into conan-io:master Oct 29, 2021
@lederernc
Copy link
Contributor Author

Thank you all!

ivanvurbanov pushed a commit to ivanvurbanov/conan-center-index that referenced this pull request Dec 2, 2021
@lederernc @ivanvurbanov
(conan-io#7843) draco/1.4.3
b05db38 
* conan-io#7646 add source for newer releases of draco

* conan-io#7646 bring some changes in from gcc-11 work

* conan-io#7646 make draco build latest version

* conan-io#7646 some clean up of conanfile for draco

* conan-io#7646 clean up imports in draco test_package/conanfile.py

* conan-io#7646 empty commit due to unknown error in ci/cd

* conan-io#7646 remove support for draco/1.4.0 and draco/1.4.0

* conan-io#7646 specify the build target correctly on windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[request] draco/1.4.1
5 participants
@lederernc @conan-center-bot @SSE4 @uilianries @danimtb