-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce system requirements, upgrade to conda 24.7.1, mamba 1.5.9, bump Docker image for linux-64 #626
Enforce system requirements, upgrade to conda 24.7.1, mamba 1.5.9, bump Docker image for linux-64 #626
Conversation
Looks like micromamba doesn't like that |
did we ever test the GLIB and OSX detection? do you think i should click merge here and start a per-release? |
Those code paths are tested in
So I think we can proceed. I guess we'll reenable the brownouts in the release after this one? |
I guess it wouldn't hurt, but we haven't tested it. Let me run the CI for conda-libmamba-solver. |
I think there has been enough feedback. I'm going to merge if this is green, and start the release process. In 1 week, we can make the "broundout" release if there aren't any major issues with this one. |
@@ -1,7 +1,7 @@ | |||
{% set name = os.environ.get("MINIFORGE_NAME", "Miniforge3") %} | |||
{% set version = os.environ.get("MINIFORGE_VERSION", "24.7.1-0") %} | |||
{% set conda_libmamba_solver_version = "24.7.0"%} | |||
{% set mamba_version = "1.5.8"%} | |||
{% set mamba_version = "1.5.9"%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also the MICROMAMBA_VERSION=1.5.8 in https://github.com/jaimergp/miniforge/blob/system-requirements-and-conda-24.7.1/scripts/build.sh#L41
If I recall correctly they are usually upgraded together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks its often forgotten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New micromamba requires the newer image for a more recent GLIBC, it looks like, so I bumped the image for x64 which was still using 2.12 IIRC.
CI is passing. No blockers here. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)