Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce system requirements, upgrade to conda 24.7.1, mamba 1.5.9, bump Docker image for linux-64 #626

Merged

Conversation

jaimergp
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@jaimergp jaimergp requested a review from a team as a code owner August 14, 2024 15:27
@jaimergp
Copy link
Member Author

Looks like micromamba doesn't like that conda create --dry-run for virtual_specs. This will need one more fix patch release in `constructor. Apologies.

@jaimergp jaimergp marked this pull request as ready for review August 20, 2024 15:29
@hmaarrfk
Copy link
Contributor

did we ever test the GLIB and OSX detection? do you think i should click merge here and start a per-release?

@jaimergp
Copy link
Member Author

jaimergp commented Aug 29, 2024

@rxm7706
Copy link

rxm7706 commented Aug 31, 2024

Question: @hmaarrfk @jaimergp
Do the bug fixes in mamba 1.5.9, warrant an update to use mamba 1.5.9 before releasing the installer.

@jaimergp
Copy link
Member Author

I guess it wouldn't hurt, but we haven't tested it. Let me run the CI for conda-libmamba-solver.

@hmaarrfk
Copy link
Contributor

I think there has been enough feedback.

I'm going to merge if this is green, and start the release process.

In 1 week, we can make the "broundout" release if there aren't any major issues with this one.

@@ -1,7 +1,7 @@
{% set name = os.environ.get("MINIFORGE_NAME", "Miniforge3") %}
{% set version = os.environ.get("MINIFORGE_VERSION", "24.7.1-0") %}
{% set conda_libmamba_solver_version = "24.7.0"%}
{% set mamba_version = "1.5.8"%}
{% set mamba_version = "1.5.9"%}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the MICROMAMBA_VERSION=1.5.8 in https://github.com/jaimergp/miniforge/blob/system-requirements-and-conda-24.7.1/scripts/build.sh#L41
If I recall correctly they are usually upgraded together

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks its often forgotten.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New micromamba requires the newer image for a more recent GLIBC, it looks like, so I bumped the image for x64 which was still using 2.12 IIRC.

@jaimergp
Copy link
Member Author

jaimergp commented Sep 3, 2024

Let me run the CI for conda-libmamba-solver.

CI is passing. No blockers here.

@jaimergp jaimergp changed the title Enforce system requirements and upgrade to conda 24.7.1 Enforce system requirements, upgrade to conda 24.7.1, mamba 1.5.9, bump Docker image for linux-64 Sep 3, 2024
@hmaarrfk hmaarrfk merged commit 102debd into conda-forge:main Sep 3, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Enforcing system requirements - Miniforge3 Blocker
4 participants