-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readme #686
base: main
Are you sure you want to change the base?
Improve readme #686
Conversation
README.md
Outdated
"Create start menu shortcuts" and "Add Miniforge3 to my PATH environment variable". The latter is | ||
not selected by default due to potential conflicts with other software. Without Miniforge3 on the | ||
path, the most convenient way to use the installed software (such as commands `conda` and `mamba`) | ||
will be via the "Miniforge Prompt" installed to the start menu. | ||
|
||
If desired, the | ||
`C:\Users\myusername\miniforge3\condabin` folder may be added to the path environment variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that for installation for all users, the path is of course different. It would be good to mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you.
Note that I don't think the failure for miniforge / Miniforge-pypy3-Linux-aarch64 has anything to do with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I've seen you around, so I know you have the best intentions.
But as is, this diff moves too many pieces around and is difficult for me to review.
Maybe somebody else can help review it, but I have limited bandwidth for this.
I want to in general move people away from this page since this isn't the right place to discuss "general conda problems".
| macOS | x86_64 | macOS >= 10.9 | [24.3.0-0](https://github.com/conda-forge/miniforge/releases/tag/24.3.0-0) | | ||
| Windows | x86_64 | Windows >= 7 | [24.9.2-0](https://github.com/conda-forge/miniforge/releases/tag/24.9.2-0) | | ||
| OS | Architecture | Minimum Version | Miniforge Version | | ||
| ------- | ------------------ | --------------- | -------------------------------------------------------------------------- | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is any of this section getting touched. it is here for historical purposes. please revert.
[Ubuntu for Raspberry PI](https://ubuntu.com/raspberry-pi). | ||
The versions listed as "System: 32-bit" are not compatible with the installers on this website. | ||
|
||
`(***)` Apple silicon builds are experimental and haven't had testing like the other platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you've removed so many lines from the front and are now starting with a "detail"
README.md
Outdated
|
||
Download the installer using curl or wget or your favorite program and run the script. | ||
For eg: | ||
If Miniforge is on the system path (default on macOS and Linux), its versions of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to change the whole idea of "Miniforge" being on the path.
"Miniforge" gets "conda" and "mamba" on your system. Once it is installed, its "job" is done. I want to help emphasize this.
My goal is to improve this README which is a real issue since I saw that many users get lost and do not manage to use the installer correctly. I don't care about this PR. It might be bad. However, I'm sure that this file has to be deeply reorganized so that people with a limited experience in conda-forge should be able in 2 minutes to install miniforge correctly and get conda/mamba in their terminals.
This PR moves and reorganizes texts and Github is not very good are showing such changes. One should really compare
and think about the user experience of a user with no strong knowledge on conda, conda-forge, Github releases pages and co.
Then what would be the right page for people wanting to install and setup conda/mamba with miniforge? |
This helps alot. thanks I didn't think of that.
"Install" is one thing. This is the right place for this. "The bash script Miniforge.sh crashed" should be addressed here. "Setup" is a different thing that starts to emcompass the old For example, this user #690 has I think we are using https://github.com/conda-forge/conda-forge.github.io as a "catchall repository". However in #602 i made the point that this repo had more stars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you I think this is a step in the right direction. Just a few comments I would like your thoughts on.
README.md
Outdated
rm -rf ${CONDA_BASE_ENVIRONMENT} | ||
## Install | ||
|
||
On all platforms, the installation should be finalized with commands like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think this is true on unix.
You should instead explain what the defaults will do, and explain why you suggestion is important.
README.md
Outdated
"Create start menu shortcuts" and "Add Miniforge3 to my PATH environment variable". The latter is | ||
not selected by default due to potential conflicts with other software. Without Miniforge3 on the | ||
path, the most convenient way to use the installed software (such as commands `conda` and `mamba`) | ||
will be via the "Miniforge Prompt" installed to the start menu. | ||
|
||
If desired, the | ||
`C:\Users\myusername\miniforge3\condabin` folder may be added to the path environment variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you.
README.md
Outdated
bash Miniforge3-$(uname)-$(uname -m).sh | ||
``` | ||
|
||
or for non-interactive install (call with `-h` to list the extra options): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or for non-interactive install (call with `-h` to list the extra options): | |
The interactive installation will prompt you to add initialize conda with your shell. This is typically with recommended workflow. | |
For non-interactive install (for example on a CI), the following command can be used (call with `-h` to list the extra options): |
```sh | ||
bash Miniforge3-$(uname)-$(uname -m).sh -b | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In non-interactive installations, the conda initialization commands will not be run by default. |
README.md
Outdated
### macOS with Homebrew | ||
|
||
On macOS, you can install miniforge with [Homebrew](https://brew.sh/) by running | ||
|
||
```sh | ||
brew install miniforge | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather remove this section. I'm happy to point to it, but I would rather omit the installation instructions and add a disclaimer that users should turn their issues to homebrew prior to asking us to do so.
dc14e0c
to
e7201d3
Compare
Thanks for the review @hmaarrfk! I'm not a good English writer but I tried to add clear explanations in e7201d3. Again, it is easier to see what it gives in https://github.com/paugier/miniforge/tree/improve-readme |
Note for myself: once we converge on something good here, it would be good to add few lines in https://conda-forge.org/download/ |
Fix #685.
I try to reorganize the README so that users can more easily find the information they need to install Miniforge.
The result can be read here https://github.com/paugier/miniforge/tree/improve-readme