Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the deploy step for gh pages #377

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add the deploy step for gh pages #377

merged 2 commits into from
Nov 15, 2024

Conversation

ericdill
Copy link
Contributor

Description

follow up from #376

you'll need to make some changes on the settings pages

image

then, a multi-step change is needed:
step 1:
image
step 2:
image

Once the above things have been set, the docs should push on any tag that gets pushed to this repo.

@ericdill ericdill requested review from xhochy and a team as code owners November 13, 2024 19:21
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 13, 2024
@jezdez
Copy link
Member

jezdez commented Nov 14, 2024

pre-commit.ci autofix

@ericdill
Copy link
Contributor Author

@jezdez fixed the linter issue

@xhochy
Copy link
Collaborator

xhochy commented Nov 15, 2024

@jezdez You need to change the environments setting. I cannot do that.

@dbast
Copy link
Member

dbast commented Nov 15, 2024

The current settings:

image

Looks correct to be and ready to merge.

@xhochy xhochy merged commit 39d66fb into conda:main Nov 15, 2024
18 checks passed
@dbast
Copy link
Member

dbast commented Nov 15, 2024

@xhochy
Copy link
Collaborator

xhochy commented Nov 15, 2024

Probably https://github.com/conda/conda-pack/actions/runs/11853502765/workflow#L154 also needs to be patched.

@dbast
Copy link
Member

dbast commented Nov 15, 2024

The error is: Error: No artifacts named "github-pages" were found for this workflow run. Ensure artifacts are uploaded with actions/upload-artifact@v4 or later.

Both actions:

list the default for artifact_name to be github-pages and we do not overwrite that.

The issue is: https://github.com/conda/conda-pack/actions/runs/11853502765/workflow#L152 ... upload happens only when tagged.

@xhochy
Copy link
Collaborator

xhochy commented Nov 15, 2024

We also need to allow tags for the environment:
image

@jezdez
Copy link
Member

jezdez commented Nov 15, 2024

@jezdez You need to change the environments setting. I cannot do that.

Can you try again?

@xhochy
Copy link
Collaborator

xhochy commented Nov 15, 2024

I did rerun the job https://github.com/conda/conda-pack/actions/runs/11859545372/job/33061200057 and it keeps failing

@jezdez
Copy link
Member

jezdez commented Nov 18, 2024

@xhochy I've fixed the environment protection rule to allow tags as well as the main branch, and now reran the whole steps (since the docs artifact has been been invalidated): https://github.com/conda/conda-pack/actions/runs/11859545372

@jezdez jezdez mentioned this pull request Nov 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants