Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Environment to EnvironmentFile in systemd unit file #1177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion debian/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ RPM_BUILDING/SOURCES/$(FULL_PACKAGE_TITLE)-$(RPM_VERSION).tar.gz: rpm-build-area
rm -rf $(FULL_PACKAGE_TITLE)-$(RPM_VERSION)
mkdir $(FULL_PACKAGE_TITLE)-$(RPM_VERSION)
cp -R $(DESTDIR)/* $(FULL_PACKAGE_TITLE)-$(RPM_VERSION)
sed "s@##RPMVERSION##@$(RPM_VERSION)@g; s@##RPMRELEASE##@$(RPM_RELEASE_ID)@g" < debian/$(FULL_PACKAGE_TITLE).spec.in > $(FULL_PACKAGE_TITLE)-$(RPM_VERSION)/$(FULL_PACKAGE_TITLE).spec
sed "s@##RPMVERSION##@$(RPM_VERSION)@g; s@##RPMRELEASE##@$(RPM_RELEASE_ID)@g" < debian/$(FULL_PACKAGE_TITLE).spec.in > $(FULL_PACKAGE_TITLE)-$(RPM_VERSION)/$(FULL_PACKAGE_TITLE).spec
rm -f $@ && tar -czf $@ $(FULL_PACKAGE_TITLE)-$(RPM_VERSION)
rm -rf $(FULL_PACKAGE_TITLE)-$(RPM_VERSION)

Expand Down
14 changes: 14 additions & 0 deletions debian/confluent-kafka-rest
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# JMX settings
#KAFKAREST_JMX_OPTS="-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false"

# JVM performance options
#KAFKAREST_JVM_PERFORMANCE_OPTS="-server -XX:+UseG1GC -XX:MaxGCPauseMillis=20 -XX:InitiatingHeapOccupancyPercent=35 -XX:+ExplicitGCInvokesConcurrent -Djava.awt.headless=true"

# Generic JVM settings you want to add
#KAFKAREST_OPTS=""

# Memory options
#KAFKAREST_HEAP_OPTS="-Xmx256M"

# Logging directory
LOG_DIR=/var/log/confluent/kafka-rest
2 changes: 1 addition & 1 deletion debian/confluent-kafka-rest.service
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ After=network.target confluent-kafka.target
Type=simple
User=cp-kafka-rest
Group=confluent
Environment="LOG_DIR=/var/log/confluent/kafka-rest"
EnvironmentFile=-/etc/sysconfig/confluent-kafka-rest
ExecStart=/usr/bin/kafka-rest-start /etc/kafka-rest/kafka-rest.properties
LimitNOFILE=100000
TimeoutStopSec=180
Expand Down
1 change: 1 addition & 0 deletions debian/confluent-kafka-rest.spec.in
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ fi
/usr/share/doc/kafka-rest

%config(noreplace) /etc/kafka-rest/*
%config(noreplace) /etc/sysconfig/confluent-kafka-rest

%clean
#used to cleanup things outside the build area and possibly inside.
Expand Down