Fix tests to support ProxyConnectionFactory #881
Conversation
|
Hey @bob-barrett, @confluentinc It looks like this brave person signed our Contributor License Agreement. 👍 Always at your service, clabot |
There was a problem hiding this comment.
Hey @bob-barrett, is it that because of some specificity only these tests will be affected by adding a ProxyConnectionFactory to our connection factory pipeline? I.e. I'm not sure I understand why is this a problem just for some tests.
| <version>7.1.0-0</version> | ||
| <!-- <version>[7.1.0-0, 7.1.1-0)</version> --> |
There was a problem hiding this comment.
Do we need to submit that temporarily? If yes, can you please add a comment explaining why? If not, is that a leftover from some testing?
There was a problem hiding this comment.
Yeah this is just so that it will consume the rest-utils local changes when running tests, I'll get rid of it before I convert this to a real PR.
| if (certificates != null && baseUri.getScheme().equals("http")) { | ||
| // If PROXY protocol is enabled, the base URI will come back as http because the first connection | ||
| // factory is not the SSL factory. If we want SSL, explicitly set the scheme here | ||
| baseUri = new URI(baseUri.toString().replace("http", "https")); |
There was a problem hiding this comment.
nit: We have loaded the JAX-RS classes for Kafka REST, so it might be a tad nicer to use javax.ws.rs.core.UriBuilder here:
baseUri = UriBuilder.fromUri(baseUri).scheme("https").build();
|
|
There was a problem hiding this comment.
@bob-barrett Is this still relevant? I assume it's not and we can close it now.
No description provided.