Support npm workspaces in set-workspace-version.js #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <[email protected]>
|
@paul-sachs, this might work, but let's make sure. Going to give it a test in the other repos tomorrow. |
paul-sachs
approved these changes
Dec 12, 2024
Signed-off-by: Timo Stamm <[email protected]>
|
I've refactored the script in 16f4364. It requires a package-lock.json file now, and checks conditions more rigorously. Workspace packages can omit a version, but only if they are private. Also updating the script in connectrpc/connect-es#1368 and bufbuild/protobuf-es#1036. |
This was referenced Dec 13, 2024
paul-sachs
approved these changes
Dec 13, 2024
paul-sachs
pushed a commit
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Paul Sachs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support npm workspaces - including patterns in set-workspace-version.js. Update logic for syncing the lock file to handle local packages without a name.
Context (and base): #497