Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arbitrum slowpath processing #6344

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

LayneHaber
Copy link
Contributor

@LayneHaber LayneHaber commented Aug 22, 2024

This pull request includes several updates to dependencies and refactors to improve the codebase's compatibility with the latest versions of the @arbitrum/sdk package. The changes involve updating package dependencies, modifying imports and exports, and adjusting test cases to reflect the new SDK structure.

Dependency Updates:

  • Updated @arbitrum/sdk to version 4.0.1 and @eth-optimism/sdk to version 3.3.2 in packages/agents/lighthouse/package.json and packages/deployments/contracts/package.json. [1] [2]

Code Refactoring:

  • Replaced L2TransactionReceipt with ChildTransactionReceipt and L1ToL2MessageGasEstimator with ParentToChildMessageGasEstimator across multiple files including packages/agents/lighthouse/src/mockable.ts and packages/agents/lighthouse/src/tasks/processFromRoot/helpers/arbitrum.ts. [1] [2] [3] [4] [5] [6] [7] [8]

Test Adjustments:

  • Updated test cases to reflect the new structure of the Arbitrum SDK by replacing instances of L2ToL1MessageReader with ChildToParentMessageReader in packages/agents/lighthouse/test/tasks/processFromRoot/helpers/arbitrum.spec.ts and packages/agents/lighthouse/test/tasks/propagate/helpers/arbitrum.spec.ts. [1] [2] [3] [4]

New Features:

  • Added a new HTTP request example for clearing cache in packages/agents/lighthouse/example.http.

These changes ensure that the codebase remains up-to-date with the latest SDK versions and maintain compatibility across different modules.## Description

  • Upgrades arbitrum sdk
  • Improve logging

Type of change

  • Docs change / dependency upgrade
  • Configuration / tooling changes
  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)

Fixes

Related pull request(s)

Copy link
Collaborator

@preethamr preethamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still fails e2e on CI

@LayneHaber LayneHaber requested a review from preethamr August 25, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants