Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature: icon-text pull-right #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add feature: icon-text pull-right #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion sass/buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,26 @@
height: 14px;
margin-top: 1px;
margin-bottom: 1px;
color: #737475;
font-size: 14px;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this getting deleted?

line-height: 1;
}

// Add the margin next to the icon if there is text in the button too
// assume 1 icon max in a button only
.btn .icon-text {
margin-right: 5px;

// For the icon is on the right side of the button text
// add the margin to the left of the text
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean up that extra space at the beginning on this comment?

&.pull-right {
margin-right: 0;
margin-left: 5px;
float: right;
}
}


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this extra line.


// This utility class add a down arrow icon to the button
.btn-dropdown:after {
font-family: "photon-entypo";
Expand Down