Pane resizing and nested/vertical pane groups (fixes #91 and #92) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In resize.js, the buildPaneTree() method loops through the DOM recursively and gets all the pane and pane-groups. During this process, splitter elements are created and appended between panes and the resizer() method is attached to each splitter onmousedown. The resizer() method takes the initial cursor position and sets the flex-basis of its neighboring panes based on the distance moved. Additionally, pane-groups can be nested in one another (`<div class="pane pane-group">`) and a new class, `.pane-group-vertical`, is used to stack panes vertically. None of these changes will affect anything that has already been built.
|
Please merge this! |
|
so this project seems dead :( who's up for forking and updating and merging all the pending PRs? |
|
I dont know if thats what you are asking for but forked photonkit as Antimatter (See: https://github.com/ExNG/antimatter) and would like to have resizeable panes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In resize.js, the
buildPaneTree()method loops through the DOM recursively and gets all the pane and pane-groups. During this process, splitter elements are created and appended between panes and theresizer()method is attached to each splitteronmousedown.resizer()takes the initial cursor position and sets the flex-basis of its neighboring panes based on the distance moved.Additionally, pane-groups can be nested in one another (
<div class="pane pane-group">) and a new class,.pane-group-vertical, is used to stack panes vertically.None of these changes will affect anything that has already been built :)