1 - upgrade facets #268
1 - upgrade facets #268
Conversation
…pe interspection to the gateway diamond so that we can know the current available functions
…compiled contracts, also gets the active facets on the gw diamond and prints out their bytecode from the chain. todo diff and run replace on any extra
…hipyard/ipc-solidity-actors into mikers/hardhatDiamondUpgrade
…hipyard/ipc-solidity-actors into mikers/hardhatDiamondUpgrade
…hipyard/ipc-solidity-actors into mikers/hardhatDiamondUpgrade
|
https://filecoinproject.slack.com/files/U042VH0A17Y/F063PUS8HB5/diamond_gateway_upgrade_2.mov here's a demo of how the hardhat command |
* initial work on upgrade sa diamond * refactor code to util * bugfix * clean up upgrade subnet actor script
* large hardhat.config.js change due to prettier * add feature to update deployments.json file when you upgrade facets * sed fix for accepting multi-line json
| // Function to upgrade the Subnet Actor Diamond | ||
| async function upgradeGatewayActorDiamond(deployments) { | ||
| // Get the Gateway Diamond address from the deployments | ||
| const gatewayDiamondAddress = deployments.Gateway |
There was a problem hiding this comment.
What happens if the one upgrading is not the one that originally deployed the gateway? (this may definitely be the case). Could we add a way to optionally pass the gateway address as an argument and try to fetch from the deployments if nothing is provided?
There was a problem hiding this comment.
I think we would need to pass the deployment.json around. It should just be public addresses! We need a lot of information to automatically do Diamond cut upgrades. We need to know the libs that the gateway and each facet was compiled with in order to determine the appropriate byte code on chain. At that point we are replicating the entire deployments json into command lines and it seems a lot easier to use the deployments json file!
| } | ||
|
|
||
| export async function getRuntimeBytecode(bytecode) { |
There was a problem hiding this comment.
I see, so in order to compare the bytecode deployed to the one locally, you do a test deployment using ganache. Do you mind adding a description of the process of upgrading in updade-sa-diamond and upgrade-gw-diamond, or even better, add a description in the README? I feel this could really help someone coming in the future to edit these scripts. Thanks 🙏
There was a problem hiding this comment.
Sure! Could I set that up in a follow on PR or do you want the readme blocking the merge?
There was a problem hiding this comment.
It is fine if we add it to a follow-up PR, let me know if you want me to open an issue for this. Mainly, it would be really useful to document:
- How upgrades work.
- The process of performing a specific upgrades.
- And the basic assets (like the
deployment.json) that needs to be provided if we want someone else to perform the upgrade.
Thanks! 🙏
Co-authored-by: adlrocha <[email protected]>
There was a problem hiding this comment.
Feel free to merge :) Just bear in mind to address my comment here: #268 (comment) in a follow-up PR if possible. Thanks!
|
follow up issue here: consensus-shipyard/ipc#126 |
use hardhat to upgrade facets attached to the gateway