Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

gh workflow check to deploy codebase on local ganache chain #367

Merged
merged 28 commits into from
Dec 21, 2023

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Dec 16, 2023

opening draft pr to test gh workflow

@snissn snissn marked this pull request as ready for review December 16, 2023 02:01
@snissn
Copy link
Contributor Author

snissn commented Dec 16, 2023

This should be working now except that we first need to merge #360 so that the build tests actually pass, as a commit to dev was introduced recently causing this to fail

Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super useful, thank you! We may need to rebase for CI to be happy (and maybe there are other things to be fixed). Feel free to merge after this!

@snissn
Copy link
Contributor Author

snissn commented Dec 19, 2023

This is somewhat blocked on consensus-shipyard/ipc#9 since 405 is causing our tests to fail, and it feels incorrect to merge a new test into our CI while it's currently failing due to a different known issue

Copy link
Contributor

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this here, but we'll need to port the build job to ipc-monorepo shortly!

@raulk raulk merged commit bf36dba into dev Dec 21, 2023
9 checks passed
@raulk raulk deleted the mikers/ghActionMake branch December 21, 2023 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants