-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): migrate vote tally #1139
Draft
cryptoAtwill
wants to merge
14
commits into
feat/topdown-enchancement
Choose a base branch
from
vote-tally
base: feat/topdown-enchancement
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoAtwill
changed the title
feat(node): vote tally initial commit
feat(node): migrate vote tally
Sep 20, 2024
Co-authored-by: cryptoAtwill <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following previous PR, this one migrates the vote tally process over.
In this PR, the following key changes are made:
stm
module, removingchain
field (not relevant to vote tally anymore) and removepause_votes
(not needed). Alsodump_votes
that dump all the votes currently collected is added. This is mainly to aid debugging in case of stuck finality.VoteTallyClient
that utilises tokio channels to communicate with the underlying reactor.VoteStore
trait that stored votes collected. Currently it's in memory store by default. Will merge with Add persistent top-down finality cache #897 when recovery modes are introduced.GossipClient
trait that vote tally uses to communicate with the underlying libp2p gossip channel. Previously it's usingipld-resolver
directly. But that crate is under utilised and quite heavy. Introducing this trait to decouple withipld-resolver
for easier testing as well.RecoverableECDSASignature
to validate signed votes from peers and sign votes for peers.