-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): integrating topdown cert into interpreters #1187
Open
cryptoAtwill
wants to merge
23
commits into
refactor-syncer
Choose a base branch
from
integrate-cert
base: refactor-syncer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pyard/ipc into integrate-cert
cryptoAtwill
force-pushed
the
integrate-observation
branch
from
October 28, 2024 09:26
ea23982
to
00e14bd
Compare
cryptoAtwill
force-pushed
the
integrate-cert
branch
from
October 28, 2024 14:19
95b74a1
to
b862797
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the previous PR, this PR integrates the new topdown flow (cert, reactor) into the interpreters.
This is the branch where all topdown changes are merged.
The key changes includes:
ECDSACertificate
that contains validator signatures with topdown checkpoint as payload. This will be used by interpreters on chain as the final outcome of topdown checkpointing.Prepare
,Process
andExec
: calls into topdown checkpoint proposal client to see if there are new proposals. If yes, it will attach the quorum cert and the actual topdown checkpoint. ForProcess
, interpreter validates the cert against the checkpoint. ForExec
, interpreter extracts the side effects from the checkpoint and executes the messages.app::run
to make sure the setup is correct.ipld-resolver
to use a more generic Vote payload instead of forceVoteRecord
. This allows more flexibility in the message to gossip.