Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgroups2: export memory max usage and swap max usage #305

Merged
merged 1 commit into from
Nov 29, 2023
Merged

cgroups2: export memory max usage and swap max usage #305

merged 1 commit into from
Nov 29, 2023

Conversation

HeRaNO
Copy link
Contributor

@HeRaNO HeRaNO commented Oct 13, 2023 •
edited
Loading

Using memory.peak and memory.swap.peak, we can account the maximum memory usage and swap usage. See torvalds/linux@8e20d4b and torvalds/linux@e0e0b41

fuweid
fuweid approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The getStatFileContentUint64 can ignore the error if the path is not found. It's safe to use the code in old kernel.

@HeRaNO
Copy link
Contributor Author

HeRaNO commented Oct 26, 2023

All checks have passed. Ready to merge.

@dmcgowan dmcgowan merged commit 2f48571 into containerd:main Nov 29, 2023
8 checks passed
@zouyee zouyee mentioned this pull request Dec 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

@fuweid fuweid fuweid approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeRaNO @dmcgowan @fuweid @dcantah